Fix z-index bug for .sparkline-tooltip in StagePerformance details page. #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot see the tooltip clearly, because it is under the modal layer now.
sopel39
approved these changes
Jul 12, 2019
|
Should we set it to something like 10000 just in case? |
I am not so familiar with related code, so I'm not sure whether it will have impact on other components if we set it too high. But in my opinion, it is ok to set it higher. |
|
please add release notes to: #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z-index of
.sparkline-tooltip(100) is smaller than that of#operator-detail-modal(1050), so when we go into query detail page → click Stage Performance → click one specific operator → hover on any of statistic, we cannot see the tooltip clearly.I think 1051 is ok, but I am not sure if it will have impact on other components.