Support smallint, tinyint, date type of Cassandra #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Feb 2, 2019
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraMetadata.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraMetadata.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraMetadata.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraPageSink.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraPageSink.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
...o-product-tests/src/main/java/io/prestosql/tests/cassandra/TestInsertIntoCassandraTable.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
support-smallint-tinyint
branch
from
664d997
to
9277d61
Compare
kokosing
reviewed
Feb 4, 2019
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
| @@ -76,6 +84,10 @@ public CassandraPageSink( | |||
| this.columnTypes = ImmutableList.copyOf(requireNonNull(columnTypes, "columnTypes is null")); | |||
| this.generateUUID = generateUUID; | |||
|
|
|||
| toCassandraDate = protocolVersion.toInt() <= ProtocolVersion.V3.toInt() ? | |||
There was a problem hiding this comment.
do we have coverage for both protocols?
There was a problem hiding this comment.
As cassandra.protocol-version in cassandra.rst, it says we can use V2, V3 and V4. Current upstream's test coverage is only V3 though.
|
Update variable name in CassandraType.java. |
findepi
reviewed
Feb 21, 2019
| @@ -70,6 +71,7 @@ | |||
| private final CassandraSession cassandraSession; | |||
| private final CassandraPartitionManager partitionManager; | |||
| private final boolean allowDropTable; | |||
| private final ProtocolVersion protocolVersion; | |||
There was a problem hiding this comment.
cmt msg "Support smallint, tinyint, date type of Cassandra"
change to
Support Cassandra smallint, tinyint and date types
| @@ -85,6 +87,7 @@ public CassandraMetadata( | |||
| this.partitionManager = requireNonNull(partitionManager, "partitionManager is null"); | |||
| this.cassandraSession = requireNonNull(cassandraSession, "cassandraSession is null"); | |||
| this.allowDropTable = requireNonNull(config, "config is null").getAllowDropTable(); | |||
| this.protocolVersion = requireNonNull(config, "config is null").getProtocolVersion(); | |||
There was a problem hiding this comment.
Annotate io.prestosql.plugin.cassandra.CassandraClientConfig#getProtocolVersion with @NotNull.
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraPageSink.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraType.java
Outdated
Show resolved
Hide resolved
@findepi Sorry, what do you mean...? |
|
(discussed offline) |
ebyhr
force-pushed
the
support-smallint-tinyint
branch
from
4504eef
to
ee5cfe9
Compare
|
Rebased to resolve conflicts, therefore force-pushed shows large diff. |
|
@ebyhr thanks! |
ebyhr
force-pushed
the
support-smallint-tinyint
branch
from
ee5cfe9
to
b6e28b5
Compare
|
Squashed and the build is green. |
|
Merged, thanks! |
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
May 24, 2021
Cherry-pick of trinodb/trino#141. This is also a fix for prestodb#15147 which tried to backport Trino prestodb#141 but that backporting was incomplete and caused the Cassandra tests to fail. Resolves: prestodb#15749 Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
May 25, 2021
Cherry-pick of trinodb/trino#141. This is also a fix for #15147 which tried to backport Trino #141 but that backporting was incomplete and caused the Cassandra tests to fail. Resolves: #15749 Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of prestodb/presto#7123