Fix create table error for file based Hive metastore with S3 #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrupp
force-pushed
the
fix-file-metastore-with-s3
branch
from
aa6e06c
to
0940b8c
Compare
findepi
reviewed
Oct 4, 2019
presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/file/FileHiveMetastore.java
Outdated
Show resolved
Hide resolved
eg AWS S3 web ui will let you create "a directory". |
|
Yeah the semantics of "a directory" in S3 sort of depend on the convention the code is using although I guess the S3 web console has the example you've given. In other areas I've seen just the presence of a key with a trailing / or for instance the Presto implementation here is just doing S3 List and checking that keys exists under that path to count it as a directory. |
|
Fixes #1858 |
S3FileSystem mkdirs doesn't actually do anything since S3 doesn't have the concept of directories. Therefore, trying to create an empty directory and immediately checking if it exists would fail since the current directory check for S3FileSystem is checking if any object keys exist under that path. This can be shortcircuited by just checking if the mkdirs call is successful.
ryanrupp
force-pushed
the
fix-file-metastore-with-s3
branch
from
0940b8c
to
5d229b9
Compare
findepi
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3FileSystem mkdirs doesn't actually do anything since S3 doesn't have the concept of directories. Therefore, trying to create an empty directory and check if it exists would fail since the current directory check for S3FileSystem is checking if any object keys exist under that path. This can be shortcircuited by just checking if the mkdirs call is successful.