Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support check constraints for UPDATE statement in engine and Delta Lake connector #17195

Merged
merged 3 commits into from Jul 4, 2023
Merged

Support check constraints for UPDATE statement in engine and Delta Lake connector #17195

merged 3 commits into from Jul 4, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Apr 24, 2023 •
edited

Description

Support check constraints for UPDATE statement in engine and Delta Lake connector

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Add support for check constraints in `UPDATE` statement. ({issue}`17195`)

# Delta Lake
* Add support for check constraints and column invariants in `UPDATE` statements. ({issue}`17195`)

@cla-bot cla-bot bot added the cla-signed label Apr 24, 2023
@github-actions github-actions bot added delta-lake Delta Lake connector tests:hive labels Apr 24, 2023
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from a16efff to 02df7bc Compare April 24, 2023 04:17
@ebyhr ebyhr self-assigned this Apr 24, 2023
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch 2 times, most recently from 1679e2e to 742c953 Compare April 24, 2023 06:42
@ebyhr ebyhr requested a review from martint April 24, 2023 09:48
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from 742c953 to 4b5a7d3 Compare April 27, 2023 01:32
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from 4b5a7d3 to 77866d9 Compare May 9, 2023 05:52
@ebyhr ebyhr requested a review from martint May 10, 2023 01:36
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from 77866d9 to a69964f Compare June 13, 2023 06:43
@ebyhr ebyhr marked this pull request as ready for review June 13, 2023 06:44
@ebyhr
Copy link
Member Author

ebyhr commented Jun 13, 2023

Rebased on master to resolve conflicts.

@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from a69964f to 7fd9f56 Compare June 14, 2023 02:19
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from 7fd9f56 to fbd3b1a Compare June 20, 2023 06:14
@ebyhr ebyhr requested a review from martint June 22, 2023 23:05
@ebyhr
Remove redundant analyzeCheckConstraints
4f24093 
It causes duplicated constraints for UPDATE statement.
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch 2 times, most recently from 3f8c027 to 4682313 Compare July 3, 2023 04:48
@ebyhr ebyhr requested a review from martint July 3, 2023 07:58
@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from 4682313 to 09162ab Compare July 3, 2023 22:01
@ebyhr ebyhr requested a review from martint July 3, 2023 22:06
@ebyhr
Copy link
Member Author

ebyhr commented Jul 3, 2023

@martint Addressed comments.

@ebyhr ebyhr force-pushed the ebi/core-update-check-constraints branch from 09162ab to 8f5d136 Compare July 4, 2023 00:32
@ebyhr ebyhr merged commit e429577 into trinodb:master Jul 4, 2023
93 checks passed
@ebyhr ebyhr deleted the ebi/core-update-check-constraints branch July 4, 2023 05:46
@github-actions github-actions bot added this to the 421 milestone Jul 4, 2023
@colebow colebow mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajaks pajaks pajaks left review comments

@martint martint martint approved these changes

Assignees

@ebyhr ebyhr

Labels
cla-signed delta-lake Delta Lake connector
Milestone
421
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebyhr @martint @pajaks