Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeltaLakeInsertTableHandle.toString() #17590

Merged
merged 1 commit into from May 22, 2023

Conversation

losipiuk
Copy link
Member

Add DeltaLakeInsertTableHandle.toString() which is printed out in query plans.

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Add DeltaLakeInsertTableHandle.toString() which is printed out
in query plans.
@cla-bot cla-bot bot added the cla-signed label May 22, 2023
@github-actions github-actions bot added the delta-lake Delta Lake connector label May 22, 2023
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@findepi
Copy link
Member

findepi commented May 22, 2023

We could have a test doing some EXPLAIN and verifying no default toString impl is used.
@ebyhr let's define a follow-up for this, for all connectors.

@losipiuk losipiuk merged commit 95d79b5 into trinodb:master May 22, 2023
47 checks passed
@github-actions github-actions bot added this to the 419 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

None yet

3 participants