Rename table function SPI package #17774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bigquery
martint
force-pushed
the
ptf-package
branch
2 times, most recently
from
9a69059
to
c1e7b91
Compare
ebyhr
approved these changes
Jun 6, 2023
martint
force-pushed
the
ptf-package
branch
2 times, most recently
from
043a9da
to
db09fa3
Compare
martint
force-pushed
the
ptf-package
branch
2 times, most recently
from
2445d92
to
f1c736a
Compare
Avoid use of obscure abbreviations and move to a more appropriate location.
ebyhr
reviewed
Jun 8, 2023
| @@ -41,7 +40,7 @@ | |||
| public DescriptorArgument(@JsonProperty("descriptor") Optional<Descriptor> descriptor) | |||
| { | |||
| this.descriptor = requireNonNull(descriptor, "descriptor is null"); | |||
| descriptor.ifPresent(descriptorValue -> checkArgument( | |||
| descriptor.ifPresent(descriptorValue -> Preconditions.checkArgument( | |||
There was a problem hiding this comment.
No, it's not. It must have been an artifact introduced by IntelliJ when doing automatic package rename. Fix here: #17811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid use of obscure abbreviations and move to a more appropriate location.
Release notes
(x) Release notes are required, with the following suggested text: