Enable queries with explicit broker URL in Pinot #17791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jun 8, 2023
| // Use global broker URI if provided explicitly via config | ||
| if (brokerUri.isPresent()) { | ||
| URI uri = brokerUri.get(); | ||
| return HostAndPort.fromParts(uri.getHost(), uri.getPort()).toString(); |
There was a problem hiding this comment.
No requested change. We build HostAndPort and change to String here and then revert to HostAndPort in getBrokerHttpUriBuilder. This is a redundant cast.
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
Could you update the PR title so that other people can understand it more easily? |
SemionPar
changed the title
SemionPar
force-pushed
the
pinot-improvements
branch
from
ef6e74a
to
23bf4cb
Compare
SemionPar
force-pushed
the
pinot-improvements
branch
from
23bf4cb
to
1685a2b
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
ebyhr
added
the
stale-ignore
ebyhr
approved these changes
May 7, 2024
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
| return brokerUrl; | ||
| } | ||
|
|
||
| @Config("pinot.broker-url") |
There was a problem hiding this comment.
(No requested change) This is not "URL" to be exact. It's good for consistency with controller property though.
Some Pinot setups don't expose publicly available broker or server URLs. This change will make possible configuring connector to make broker queries.
SemionPar
force-pushed
the
pinot-improvements
branch
from
1685a2b
to
67ba0b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow using connector in broker-only queries mode with Pinot installations where broker URLs returned by Pinot APIs are unreachable to Trino.
Additional context and related issues
Setting config in the following way
will make connector execute broker-only queries to explicit broker URL.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: