Remove redundant ORDER BY from WITH and views #18159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radek-kondziolka
approved these changes
Jul 7, 2023
martint
force-pushed
the
redundant-order-by
branch
2 times, most recently
from
379b963
to
7d1d87f
Compare
Be intentional about whether the analyzer is being called for a top-level statement, which does not require or expect an outer scope to exist.
The merge componenents were being planned with the scope passed in to the method, which is empty due to merge being a top-level statement. Technically, this is incorrect, as those components cannot exist without an outer scope.
martint
force-pushed
the
redundant-order-by
branch
from
7d1d87f
to
1b276af
Compare
dain
approved these changes
Aug 3, 2023
| @@ -457,23 +457,28 @@ class StatementAnalyzer | |||
|
|
|||
| public Scope analyze(Node node) | |||
| { | |||
| return analyze(node, Optional.empty()); | |||
| return analyze(node, Optional.empty(), true); | |||
| } | |||
|
|
|||
| public Scope analyze(Node node, Scope outerQueryScope) | |||
There was a problem hiding this comment.
Consider getting rid of this method and making the caller explicitly say top level or not.
There was a problem hiding this comment.
Actually, this method implies it's not top-level (since there's an outer query scope). It's the method below that is not necessary. I'll update its usages and remove it.
Track whether the query being analyzed is at the top level to decide whether the ORDER BY is ineffective.
martint
force-pushed
the
redundant-order-by
branch
from
1b276af
to
e651e6f
Compare
|
Any suggestion for release note entry @martint ? Also .. does this need doc update? |
|
@mosabua, added it to the PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORDER BY without LIMIT / OFFSET is irrelevant unless it's in the top-level query.
Alternative to #18153
Release notes
(x) Release notes are required, with the following suggested text: