Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the JVM default charset is UTF-8 #18657

Merged
merged 1 commit into from Aug 12, 2023
Merged

Require the JVM default charset is UTF-8 #18657

merged 1 commit into from Aug 12, 2023

Conversation

dain
Copy link
Member

@dain dain commented Aug 11, 2023

Java changed the default charset to UTF-8 in JEP 400 which is in Java 19

The error message is:

Trino requires that the default charset is UTF-8 (found XYZ). This can be set with the JVM command line option -Dfile.encoding=UTF-8

Release notes

( ) Release notes are required, with the following suggested text:

# General
* The JVM default charset is now required to be UTF-8. This can be set with the JVM command line option -Dfile.encoding=UTF-8. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 11, 2023
@mosabua
Copy link
Member

mosabua commented Aug 11, 2023

Should we update the docs to include that info?

@dain
Copy link
Member Author

dain commented Aug 11, 2023

Should we update the docs to include that info?

@mosabua Yes. Where is that?

Java changed the default charset to UTF-8 in JEP 400 which is in Java 19
@dain
Copy link
Member Author

dain commented Aug 11, 2023

@mosabua docs added

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are good even though we officially talk about just using 17 .. its still good to have.

@github-actions github-actions bot added the docs label Aug 12, 2023
@dain
Copy link
Member Author

dain commented Aug 12, 2023

Docs are good even though we officially talk about just using 17 .. its still good to have.

When we move to 21 in a few months, we need to rewrite a bunch of this.

@dain dain merged commit d6f8a75 into trinodb:master Aug 12, 2023
87 checks passed
@dain dain deleted the utf-8 branch August 12, 2023 03:51
@github-actions github-actions bot added this to the 424 milestone Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants