Support altering column comments in Hive Glue catalogs #19076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Sep 19, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
|
/test-with-secrets sha=17cb3d1477a8d7891b5916476715a0bbced985bf |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6233258473 |
alexjo2144
force-pushed
the
hive/glue-column-comments
branch
from
17cb3d1
to
a8657cc
Compare
alexjo2144
force-pushed
the
hive/glue-column-comments
branch
from
a8657cc
to
f16036d
Compare
|
Test and sanity checks added, PTAL |
findepi
approved these changes
Sep 22, 2023
| for (int i = 0; i < columns.size(); i++) { | ||
| // Glue columns are always lowercase | ||
| if (columns.get(i).getName().equals(columnName)) { | ||
| index.ifPresent(ignored -> { |
There was a problem hiding this comment.
ordinary if (index.isPresent()) would free you from having to name a variable you ignore
|
/test-with-secrets sha=f16036dd4d290ef621025a6b4e0eeb4e531ac620 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6271687721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support altering column comments in Hive Glue catalogs.
Additional context and related issues
Extracted from: #19073
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: