New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date to varchar coercion for hive #19500
Merged
Praveen2112
merged 1 commit into
trinodb:master
from
findinpath:findinpath/hive-date-to-varchar-coercion
Dec 12, 2023
Merged
Add date to varchar coercion for hive #19500
Praveen2112
merged 1 commit into
trinodb:master
from
findinpath:findinpath/hive-date-to-varchar-coercion
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
findinpath/hive-date-to-varchar-coercion
branch
from
October 23, 2023 20:33
127a286
to
237a657
Compare
homar
reviewed
Oct 24, 2023
public void testDateToVarchar() | ||
{ | ||
assertDateToVarcharCoercion(createUnboundedVarcharType(), LocalDate.of(2023, 1, 10), "2023-01-10"); | ||
assertDateToVarcharCoercion(createUnboundedVarcharType(), LocalDate.of(1899, 12, 31), "1899-12-31"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a thought, for opposite way conversion (VARCHAT => DATE) we only allow dates greater than 01.01.1900 is it ok to allow broader range here?
homar
approved these changes
Oct 24, 2023
Praveen2112
force-pushed
the
findinpath/hive-date-to-varchar-coercion
branch
2 times, most recently
from
November 6, 2023 07:35
95dc3fc
to
6b328f6
Compare
findinpath
force-pushed
the
findinpath/hive-date-to-varchar-coercion
branch
from
November 14, 2023 15:13
6b328f6
to
e36e883
Compare
Praveen2112
approved these changes
Dec 1, 2023
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/BaseTestHiveCoercion.java
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/hive-date-to-varchar-coercion
branch
from
December 4, 2023 19:38
e36e883
to
1979724
Compare
Unrelated CI failure #16315 |
Thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add date to varchar coercion for hive.
Enable the Hive users to retrieve the information from their tables after performing queries which change
date
columns tovarchar
.Hive sample DDL query:
Additional context and related issues
After changing the column type, dates to far in the future are displayed as expected in Trino, but not in Hive:
In any case, dates to far in the future seem not to be queryable anyway even when working with
date
column type in HiveRelease notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: