Add Slice support to reduce_agg function #20452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/reduce-agg-slice
branch
from
314c85a
to
1525c4e
Compare
electrum
approved these changes
Jan 26, 2024
dain
approved these changes
Jan 26, 2024
|
Hi, does this resolve issue 2089? The doc just says "others". Not sure if complex data types are covered. Thanks |
|
@mrbrahman if they are backed by |
|
Hi, looking for "row" datatype support. Thanks |
|
@mrbrahman it's not supported. row() is backed up by a different data structure |
|
Is JSON datatype supported? |
|
@mrbrahman it should be, JSON is backed-by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled upon
JDK-8017163reference while going through the process of cleaning up after switching to JDK 21. Since it's solved, I've added a support to Slice serialization in the reduce_agg function.