Add support for count distinct pushdown for snowflake #21130
Conversation
chenjian2664
force-pushed
the
sn_pd_count_dis
branch
from
bfb3214
to
ea1058e
Compare
plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeConnectorTest.java
Outdated
Show resolved
Hide resolved
|
Could you rebase on master to resolve conflicts? |
chenjian2664
force-pushed
the
sn_pd_count_dis
branch
from
ea1058e
to
191ca97
Compare
|
/test-with-secrets sha=191ca97f5fd58187552b4c14c405a7c2896c637c |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8447629959 |
|
Could you rebase on master to resolve conflicts? |
|
/test-with-secrets sha=d917182dfc5684c36758cca555353ed4f765d589 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8460542297 |
|
/test-with-secrets sha=e8503af4d4b8bcedce5f77abf1d955d5ad3e555b |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8460568445 |
| @@ -66,10 +66,8 @@ protected SqlExecutor onRemoteDatabase() | |||
| protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior) | |||
| { | |||
| return switch (connectorBehavior) { | |||
| case SUPPORTS_AGGREGATION_PUSHDOWN -> true; | |||
There was a problem hiding this comment.
@chenjian2664 I reverted your change as SUPPORTS_AGGREGATION_PUSHDOWN and SUPPORTS_PREDICATE_PUSHDOWN are true by default.
Release notes
(x) Release notes are required, with the following suggested text: