Specify Locale for DecimalFormat #21136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Mar 18, 2024
wendigo
reviewed
Mar 18, 2024
| @@ -55,7 +57,7 @@ public final class DoubleOperators | |||
| private static final double MIN_BYTE_AS_DOUBLE = -0x1p7; | |||
| private static final double MAX_BYTE_PLUS_ONE_AS_DOUBLE = 0x1p7; | |||
|
|
|||
| private static final ThreadLocal<DecimalFormat> FORMAT = ThreadLocal.withInitial(() -> new DecimalFormat("0.0###################E0")); | |||
There was a problem hiding this comment.
The same problem lives in RealOperators. Can we fix both @kasiafi ?
findepi
reviewed
Mar 18, 2024
core/trino-main/src/main/java/io/trino/type/DoubleOperators.java
Outdated
Show resolved
Hide resolved
|
I guess tests cannot catch problems like this because we have |
Before this change, when casting real or double to varchar, we used DecimalFormat without specified Locale. It defaulted to user's locale, causing inconsistent formatting and test failures. For `AU`, the `E` in scientific notation is lowercase.
kasiafi
force-pushed
the
510_ScientificNotationLocale
branch
from
692e48f
to
4236fa6
Compare
|
@findepi AC |
wendigo
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when casting real or double to varchar, we used DecimalFormat without specified Locale. It defaulted to user's locale, causing inconsistent formatting and test failures. For example, with locale
AU, theEin scientific notation is lowercase.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: