Switch to JDK 22 in the runtime #21161
Conversation
|
Failures so far:
|
wendigo
force-pushed
the
serafin/jdk-22-ready
branch
5 times, most recently
from
8faa202
to
862eae8
Compare
...n/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/metadata/ShardCleaner.java
Outdated
Show resolved
Hide resolved
core/trino-server-rpm/src/test/java/io/trino/server/rpm/ServerIT.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jdk-22-ready
branch
3 times, most recently
from
6cc1630
to
31bbbf0
Compare
wendigo
changed the title
wendigo
changed the title
wendigo
force-pushed
the
serafin/jdk-22-ready
branch
2 times, most recently
from
87d7a64
to
311c5bf
Compare
|
@electrum PTAL for raptor changes |
are both still accurate? |
|
@findepi updated |
wendigo
force-pushed
the
serafin/jdk-22-ready
branch
from
311c5bf
to
9255aec
Compare
|
Just rebased |
wendigo
force-pushed
the
serafin/jdk-22-ready
branch
from
9255aec
to
90f9aac
Compare
| @@ -76,6 +76,9 @@ public void testInstallUninstall() | |||
| // Release names as in the https://api.adoptium.net/q/swagger-ui/#/Release%20Info/getReleaseNames | |||
| testInstall("jdk-21.0.2+13", "/usr/lib/jvm/temurin-21", "21"); | |||
| testUninstall("jdk-21.0.2+13", "/usr/lib/jvm/temurin-21", "21"); | |||
|
|
|||
| testInstall("jdk-22+36", "/usr/lib/jvm/temurin-22", "22"); | |||
| testUninstall("jdk-22+36", "/usr/lib/jvm/temurin-22", "22"); | |||
There was a problem hiding this comment.
The expectedJavaVersion parameter in testUninstall is not used, and Error Prone fails the build for me locally on this. Why isn't it failing on CI?
There was a problem hiding this comment.
because it skips some mdules -
trino/.github/workflows/ci.yml
Lines 199 to 200 in 0714cae
There was a problem hiding this comment.
Let's fix both issues
There was a problem hiding this comment.
not sure why though. It's been there since beginning - 7949e41
There was a problem hiding this comment.
Maybe we thought that there's no Java code in that module (like it's the case for docs and rpm modules)?
There was a problem hiding this comment.
Oh, sorry, I now realized that this is the RPM module :D
There was a problem hiding this comment.
But yeah, I too would assume that there's no Java code here
|
Just a note -- jdk22 is a short term release; depending on that is going to cause issues in some enterprise environments that only stick to LTS versions of java. Only a problem if jdk22 features begin to get baseline, which will result in forcing longish upgrade cycles for enterprise customers. |
|
@covalesj we are aware of that. However the benefits outweigh these issues. We will continue to stay with the latest Java release going forward. What JDK is used is mostly an implementation detail. Especially in container-based deployments there is no impact. For non-container based deployments users will just have to choose to stay with old Trino and old Java .. or go with new features, more performance, timely security fixes, bug fixes and overall improvements all around. Also keep in mind that the "support" window for Java release is completely variable between vendors and you can get support for any release. We are using Eclipse Temurin as an open source project for our testing and inclusion in the container. |
Release notes: use Java 22 in the docker image.