Get table comments from RDBMS in bulk #21238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/get-table-comments-from-rdbms-in-bulk-2ef717
branch
from
3d1510e
to
7eb6b09
Compare
Instead of doing 1 call of type A and then N calls of type B, the connector now issues 1 call of type A and 0 other calls |
Improve speed of getting table comments in JDBC connectors manifold. Get them all at once.
findepi
force-pushed
the
findepi/get-table-comments-from-rdbms-in-bulk-2ef717
branch
from
7eb6b09
to
5a19158
Compare
ebyhr
approved these changes
Mar 26, 2024
findepi
deleted the
findepi/get-table-comments-from-rdbms-in-bulk-2ef717
branch
|
Do we want a release notes entry for this on all JDBC connectors or is it not worth mentioning @findepi |
|
sure, please do |
|
Done |
|
looks awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve speed of getting table comments in JDBC connectors manifold. Get them all at once.