Support table comment for Snowflake connector #21305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
requested changes
Mar 29, 2024
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
Allow create table with comment. Also allow to set table comment for Snowflake tables.
chenjian2664
force-pushed
the
sn_table_comment
branch
from
e9b267e
to
be5b003
Compare
|
/test-with-secrets sha=be5b0035e67d1d06242f3ac33cc3feb4cf53828b |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8496283293 |
ebyhr
approved these changes
Mar 31, 2024
|
Amazing @chenjian2664 .. you are on a roll! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow create table with comment.
Also allow to set table comment for Snowflake tables.
Description
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: