Replace Aggregation RemoveInput manual WindowAggregation class #21349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Apr 17, 2024
core/trino-spi/src/main/java/io/trino/spi/function/WindowAccumulator.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/WindowAccumulator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Which warnings does fix? It's not very obvious from the diff.
There was a problem hiding this comment.
The main point is these are mechanical suggestions from intellij. But the summary is:
- class can be converted to a record is a warning
- method can be private
- method is unused
- use Arrays.stream
- Use List.getFirst
core/trino-main/src/main/java/io/trino/operator/aggregation/AccumulatorCompiler.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/aggregation/RealSumAggregation.java
Outdated
Show resolved
Hide resolved
Remove input has been replaced with custom window accumulator implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aggregation remove input is used solely for window functions. The replaces the
@RemoveInputannotation and adds a WindowAggregation implementation. This can simplify the state required in a traditional aggregation since removal is now only allowed in a WindowAggregation implementation. Although both a remove method and the window aggregation could be supported at the same time, the extra complexity of both isn't worth it given how rarely the remove method is added.Release notes
(X) Release notes are required, with the following suggested text: