Allow using filter when materializing BigQuery views #21488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/bigquery-view-filter
branch
from
22151a5
to
fda4921
Compare
wendigo
reviewed
Apr 15, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplit.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-view-filter
branch
from
fda4921
to
f45b8ee
Compare
wendigo
reviewed
Apr 15, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplit.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQuerySplitManager.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQuerySplitManager.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQuerySplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQuerySplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQuerySplitManager.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQuerySplitManager.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-view-filter
branch
from
f45b8ee
to
29b4590
Compare
wendigo
reviewed
Apr 15, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplit.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-view-filter
branch
2 times, most recently
from
47f31f1
to
d892f81
Compare
wendigo
reviewed
Apr 16, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplitManager.java
Outdated
Show resolved
Hide resolved
wendigo
previously requested changes
Apr 16, 2024
wendigo
reviewed
Apr 16, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplitManager.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-view-filter
branch
from
219fdb0
to
9d6e3b7
Compare
wendigo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow using filter when materializing BigQuery views to avoid generating huge temporary tables.
Release notes
(x) Release notes are required, with the following suggested text: