Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable bigquery.arrow-serialization.enabled by default #21580

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Enable bigquery.arrow-serialization.enabled by default #21580

merged 1 commit into from
Apr 26, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Apr 17, 2024 •
edited

Description

Enable bigquery.arrow-serialization.enabled by default

Release notes

(x) Release notes are required, with the following suggested text:

# BigQuery
* Enable `bigquery.arrow-serialization.enabled` by default. 
  `--add-opens=java.base/java.nio=ALL-UNNAMED` must be added to`jvm-config` ({issue}`21580`)

@cla-bot cla-bot bot added the cla-signed label Apr 17, 2024
@github-actions github-actions bot added docs bigquery BigQuery connector labels Apr 17, 2024
hashhar
hashhar approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@hashhar
Copy link
Member

hashhar commented Apr 25, 2024

Do we want to merge this or we wait for some feedback/tests?

@ebyhr ebyhr force-pushed the ebi/bigquery-arrow-enable-default branch from b3e5da6 to c793199 Compare April 25, 2024 22:56
@ebyhr
Copy link
Member Author

ebyhr commented Apr 25, 2024

Rebased on master to resolve conflicts.

I think we can merge as-is.

@ebyhr ebyhr merged commit ada0d68 into master Apr 26, 2024
22 checks passed
@ebyhr ebyhr deleted the ebi/bigquery-arrow-enable-default branch April 26, 2024 03:05
@github-actions github-actions bot added this to the 446 milestone Apr 26, 2024
@colebow colebow mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
bigquery BigQuery connector cla-signed docs
Milestone
446
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebyhr @hashhar @wendigo