Improve speed when listing table comments in BigQuery #21581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/bigquery-bulk-table-comments
branch
5 times, most recently
from
8fe0a80
to
cef7a46
Compare
ebyhr
force-pushed
the
ebi/bigquery-bulk-table-comments
branch
2 times, most recently
from
5546249
to
bf0e99f
Compare
ebyhr
commented
Apr 22, 2024
Comment on lines
418
to
422
| private static String unquote(String quoted) | ||
| { | ||
| return quoted.substring(1, quoted.length() - 1) | ||
| .replace("\"\"", "\""); |
There was a problem hiding this comment.
The option_value is quoted as BigQuery official documentation says: https://cloud.google.com/bigquery/docs/information-schema-table-options#example_2
Special characters are tested in BaseConnectorTest#testCommentTableSpecialCharacter().
ebyhr
commented
Apr 22, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Show resolved
Hide resolved
pajaks
reviewed
Apr 25, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-bulk-table-comments
branch
from
bf0e99f
to
e4c9e33
Compare
hashhar
approved these changes
Apr 25, 2024
ebyhr
force-pushed
the
ebi/bigquery-bulk-table-comments
branch
from
e4c9e33
to
9fe2a53
Compare
ebyhr
force-pushed
the
ebi/bigquery-bulk-table-comments
branch
3 times, most recently
from
fa421f9
to
35602ca
Compare
pajaks
approved these changes
Apr 30, 2024
wendigo
reviewed
Apr 30, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-bulk-table-comments
branch
from
35602ca
to
4291c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test results with 46 tables:
Release notes
(x) Release notes are required, with the following suggested text: