Nullify DriverFactory#operatorFactories on noMoreDrivers #21706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this factories release memory in theirs |
sopel39
reviewed
Apr 25, 2024
core/trino-main/src/main/java/io/trino/operator/DriverFactory.java
Outdated
Show resolved
Hide resolved
radek-kondziolka
force-pushed
the
nullify_operator_factories
branch
2 times, most recently
from
ab9e612
to
4cd5c78
Compare
We could do it but taking this approach (proposed one) addresses potential issues for all operators. |
radek-kondziolka
force-pushed
the
nullify_operator_factories
branch
2 times, most recently
from
8748938
to
3e593ef
Compare
sopel39
reviewed
Apr 25, 2024
radek-kondziolka
force-pushed
the
nullify_operator_factories
branch
from
3e593ef
to
0018706
Compare
sopel39
reviewed
Apr 25, 2024
| @@ -88,6 +90,7 @@ public OptionalInt getDriverInstances() | |||
| return driverInstances; | |||
| } | |||
|
|
|||
| @Nullable | |||
There was a problem hiding this comment.
it should be from jakarta.annotation package
|
there are maven failures, see https://github.com/trinodb/trino/pull/21706/files#r1580024450 |
sopel39
approved these changes
Apr 25, 2024
radek-kondziolka
force-pushed
the
nullify_operator_factories
branch
2 times, most recently
from
3210779
to
c92205a
Compare
It can happen that operator factories live longer than operators what can cause that considerable amount of memory is not freed.
radek-kondziolka
force-pushed
the
nullify_operator_factories
branch
from
c92205a
to
f740c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It can happen that operator factories live longer than operators what can cause that considerable amount of memory is not freed. Specifically,
PartitionedLookupSourceFactory(that retained size can be very big) is kept by chain of referenceJoinBridgeManager <- HashBuilderOperator <- operatorFactories <- driverFactoryeven if operators are finished.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: