Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease query.low-memory-killer.delay to 30s #21719

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

raunaqmorarka
Copy link
Member

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Reduce delay in killing of queries when the cluster runs out of memory ({issue}`issuenumber`)

Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check how often coordinator updates status of worker memory pools? I think it's few secs at most

@raunaqmorarka
Copy link
Member Author

Could you check how often coordinator updates status of worker memory pools? I think it's few secs at most

SqlQueryManager will trigger async refreshes when it finds worker memory pool info to be more than 1 second stale and it's running this loop every second.

@raunaqmorarka raunaqmorarka merged commit c4a1c91 into trinodb:master Apr 26, 2024
98 checks passed
@raunaqmorarka raunaqmorarka deleted the oom-delay branch April 26, 2024 09:25
@github-actions github-actions bot added this to the 446 milestone Apr 26, 2024
@findepi
Copy link
Member

findepi commented Apr 26, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants