Ignore failing Hive views during listing #21748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Apr 29, 2024
pajaks
force-pushed
the
pajaks/hive_metadata_listing_error
branch
2 times, most recently
from
62bf4cf
to
eda709c
Compare
pajaks
changed the title
ebyhr
approved these changes
Apr 29, 2024
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveMetadataListing.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveMetadataListing.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveMetadataListing.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveMetadataListing.java
Outdated
Show resolved
Hide resolved
pajaks
force-pushed
the
pajaks/hive_metadata_listing_error
branch
from
eda709c
to
04e2a4d
Compare
pajaks
force-pushed
the
pajaks/hive_metadata_listing_error
branch
from
59ec263
to
35d8cf6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of view error (e.g Table StorageDescriptor is null) listing is failing.
After this change HiveMetadata::getViews will filter out such views.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: