Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom trace attributes to query session #22178

Open
mduggan-starburst opened this issue May 28, 2024 · 2 comments
Open

Add custom trace attributes to query session #22178

mduggan-starburst opened this issue May 28, 2024 · 2 comments

Comments

@mduggan-starburst
Copy link

In order to help isolate and analyze query behavior from specific clients, there should be custom trace attributes that can be added to query Session objects. This would allow for adding these additional tracing attributes to QueryMonitor logging and OptenTelemetry Trace objects.

@findepi
Copy link
Member

findepi commented May 29, 2024

Trino CLI has these options

...
      --client-info=<info>   Extra information about client making query
      --client-tags=<tags>   Client tags
...

can any of these be used for the purpose?

@mduggan-starburst
Copy link
Author

Trino CLI has these options

...
      --client-info=<info>   Extra information about client making query
      --client-tags=<tags>   Client tags
...

can any of these be used for the purpose?

Certainly for the client tags. I'll look into the client info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants