Allow to convert to varchar an unsupported type in Phoenix #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #2426 |
kokosing
force-pushed
the
origin/master/204_phoenix
branch
from
7da27a0
to
671779f
Compare
|
Fixes #2416 |
kokosing
force-pushed
the
origin/master/204_phoenix
branch
from
671779f
to
a7cda67
Compare
|
@kokosing Could you resolve conflicts? |
kokosing
force-pushed
the
origin/master/204_phoenix
branch
from
a7cda67
to
15e6a9f
Compare
ebyhr
reviewed
Jan 8, 2020
| @@ -36,7 +36,6 @@ public void testDefaults() | |||
| .setConnectionUrl(null) | |||
| .setCaseInsensitiveNameMatching(false) | |||
| .setCaseInsensitiveNameMatchingCacheTtl(new Duration(1, MINUTES)) | |||
| .setJdbcTypesMappedToVarchar(null) | |||
| .setUnsupportedTypeHandling(UnsupportedTypeHandling.IGNORE) | |||
There was a problem hiding this comment.
We should remove setUnsupportedTypeHandling instead of setJdbcTypesMappedToVarchar
| @@ -16,7 +16,6 @@ | |||
| import com.google.common.base.Splitter; | |||
| import com.google.common.collect.ImmutableSet; | |||
| import io.airlift.configuration.Config; | |||
| import io.airlift.configuration.ConfigDescription; | |||
There was a problem hiding this comment.
Revert (other properties have @ConfigDescription)
Also, we can remove unused unsupportedTypeHandling variable.
| @@ -272,7 +272,10 @@ public BaseJdbcClient( | |||
| .setComment(comment) | |||
| .build()); | |||
| } | |||
| verify(columnMapping.isPresent() || getUnsupportedTypeHandling(session) == IGNORE, "Unsupported type handling is set to %s, but toPrestoType() returned empty"); | |||
There was a problem hiding this comment.
PostgreSqlClient also has the same logic.
| withUnsupportedType(CONVERT_TO_VARCHAR), | ||
| "INSERT INTO test_timestamp VALUES (4, '2002-05-30 09:30:10.500')", | ||
| "Underlying type that is mapped to VARCHAR is not supported for INSERT: TIMESTAMP"); | ||
| executeInPhoenix("DROP TABLE tpch.test_timestamp"); |
There was a problem hiding this comment.
Suggested change
| executeInPhoenix("DROP TABLE tpch.test_timestamp"); | |
| assertUpdate("DROP TABLE test_timestamp"); |
kokosing
force-pushed
the
origin/master/204_phoenix
branch
from
15e6a9f
to
154f68e
Compare
|
Comments addressed. @ebyhr Thanks for the review! |
|
Unfortunately, it conflicted again. |
kokosing
force-pushed
the
origin/master/204_phoenix
branch
from
154f68e
to
d60600e
Compare
|
Rebased |
Sessions properties are registered per catalog (an instance of connector).
kokosing
force-pushed
the
origin/master/204_phoenix
branch
from
d60600e
to
c49faf8
Compare
ebyhr
approved these changes
Jan 8, 2020
This was referenced Jan 8, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to convert to varchar an unsupported type in Phoenix