Add support for COMMENT ON COLUMN statement #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Syntax looks good. It's consistent with COMMENT ON TABLE and the eventual direction we're going with this. See (#200 (comment) for previous discussions) |
martint
requested changes
Jun 25, 2020
| @Test | ||
| public void testCommentColumn() | ||
| { | ||
| assertStatement("COMMENT ON COLUMN a.b IS 'test'", new Comment(Comment.Type.COLUMN, QualifiedName.of("a", "b"), Optional.of("test"))); |
There was a problem hiding this comment.
Add tests for other forms of column names: E.g., catalog.schema.table.column, schema.table.column, column, etc.
| @@ -58,6 +61,23 @@ public String getName() | |||
|
|
|||
| metadata.setTableComment(session, tableHandle.get(), statement.getComment()); | |||
| } | |||
| else if (statement.getType() == Comment.Type.COLUMN) { | |||
| QualifiedObjectName tableName = createQualifiedObjectName(session, statement, statement.getName().getPrefix().get()); | |||
| Optional<TableHandle> tableHandle = metadata.getTableHandle(session, tableName); | |||
There was a problem hiding this comment.
This needs to check if the name has a single part. E.g., if the user enters COMMENT ON foo IS ...
ebyhr
force-pushed
the
comment-on-column
branch
2 times, most recently
from
9e06768
to
2a96c46
Compare
|
Updated. |
martint
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2242