Expand support of types handled in EXPLAIN (TYPE IO) #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Mar 20, 2019
presto-main/src/main/java/io/prestosql/sql/planner/planPrinter/PlanPrinter.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Mar 20, 2019
presto-main/src/main/java/io/prestosql/sql/planner/planPrinter/PlanPrinterUtil.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Mar 20, 2019
presto-main/src/main/java/io/prestosql/sql/planner/planPrinter/PlanPrinterUtil.java
Outdated
Show resolved
Hide resolved
|
Left few minor comments. Thank you for creating this PR! |
|
Thanks for the feedback, @ebyhr. I've pushed commits to address them. |
martint
reviewed
Mar 23, 2019
presto-main/src/main/java/io/prestosql/sql/planner/planPrinter/IoPlanPrinter.java
Outdated
Show resolved
Hide resolved
martint
requested changes
Apr 2, 2019
presto-main/src/main/java/io/prestosql/sql/planner/planPrinter/IoPlanPrinter.java
Outdated
Show resolved
Hide resolved
presto-tests/src/test/java/io/prestosql/sql/planner/planPrinter/TestPlanPrinterUtil.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/sql/planner/planPrinter/PlanPrinterUtil.java
Outdated
Show resolved
Hide resolved
|
@JamesRTaylor, can you rebase and fix the conflicts so that Travis can run? |
|
I made a couple of minor adjustments, rebased and merged it. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the EXPLAIN (TYPE IO) command has very limited support for column types. This PR expands that to include the primitive column types.