Improve nested loop operator #5276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
2 times, most recently
from
09bdec1
to
c416dcb
Compare
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
2 times, most recently
from
2fad348
to
c16fb21
Compare
|
Marking as WIP - I think I have a much better approach |
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
2 times, most recently
from
5c80b06
to
0f6108d
Compare
pettyjamesm
commented
Sep 24, 2020
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinOperator.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
2 times, most recently
from
e3e986f
to
b895710
Compare
sopel39
reviewed
Sep 25, 2020
presto-main/src/main/java/io/prestosql/operator/NestedLoopBuildOperator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinOperator.java
Show resolved
Hide resolved
|
@pettyjamesm which of the optimizations in this PR are valid when we assume that cross join cannot do build pruning (which it cant)? Can the PR be simplified? |
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
3 times, most recently
from
adba160
to
e5ff6ac
Compare
Good to know and thanks for the review. I've stripped out the parts that aren't necessary when we can safely assume no pruning actually happens. Should be ready for another review now. |
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
from
e5ff6ac
to
b8ac631
Compare
sopel39
reviewed
Sep 29, 2020
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinOperator.java
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
from
b8ac631
to
07b77f6
Compare
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
2 times, most recently
from
a3f9ecf
to
bf9ac12
Compare
martint
reviewed
Oct 5, 2020
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinOperator.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
3 times, most recently
from
bb27cc7
to
40a966a
Compare
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
from
40a966a
to
98b4b70
Compare
martint
requested changes
Oct 7, 2020
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinOperator.java
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinPagesBuilder.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/NestedLoopJoinPagesBuilder.java
Outdated
Show resolved
Hide resolved
Avoids varargs empty array creation per call for these usage sites
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
2 times, most recently
from
b978035
to
dd1dbfd
Compare
- Modifies NestedLoopJoinPagesBuilder to combine empty pages (aka: positionCount only pages) when the build side of the nested loop join is empty - Handles the case where either probe or build side outputs are empty and position counts are fewer by emitting the same page repeatedly, avoiding unnecessary per-iteration allocations - Reduces the amount of block array copies made in the standard case by reusing a block buffer to build each page and letting the Page constructor clone it (ie: 1/2 as many allocations) - Nullifies the output iterator as well as the probe page when finished iterating through it to make the referenced pages elligible for GC. Also nullifies more fields when the operator is closed for the same reason.
pettyjamesm
force-pushed
the
improve-nested-loop-operator
branch
from
dd1dbfd
to
cd38e2c
Compare
martint
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a constructor to the
Pageclass for when no blocks are passed as arguments.