New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit amount of native memory used for NIO buffers #542
Conversation
@findepi Have added the default value as |
@Praveen2112 thanks for the PR. |
@Praveen2112 please add this also after https://github.com/prestosql/presto/blob/cdc3f3420e451ea65b3e2bbc1fa8561f9fbe9738/presto-product-tests/conf/presto/etc/jvm.config#L15 @martint if you're OK with this change, I would also recommend adding this to https://github.com/prestosql/presto/blob/9622c3f959f828f3614790c44ab5d545d5cea5ef/presto-docs/src/main/sphinx/installation/deployment.rst#jvm-config |
We used to set this to 1MB at FB. |
I'm ok with it, but in general, we should try to figure out why this is happening. The setting is a bandaid to a problem that can be solved by fixing the calling code to size buffers more carefully. |
adc0aba
to
5fd305a
Compare
@findepi Have updated the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the default value of jdk.nio.maxCachedBufferSize to 2MB. If we did not set this JVM would take the entire System memory as the maximum buffer size and it will result in increase in non-heap memory for the JVM process
5fd305a
to
0d83fb9
Compare
@findepi Thanks for pointing it out. I have updated it. |
Set the default value of jdk.nio.maxCachedBufferSize to 2MB. If we did not set this JVM would take the entire System memory as the maximumbuffer size and it will result in increase in non-heap memory for the JVM process.