Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DISTINCT inside IN subquery expression #551

Merged
merged 2 commits into from Apr 1, 2019
Merged

Remove DISTINCT inside IN subquery expression #551

merged 2 commits into from Apr 1, 2019

Conversation

Praveen2112
Copy link
Member

@cla-bot cla-bot bot added the cla-signed label Mar 27, 2019
@Praveen2112
Copy link
Member Author

Praveen2112 commented Mar 27, 2019 •
edited

@kokosing Please review them and let me know if there is changes.

@Praveen2112 Praveen2112 force-pushed the distinct_in_predicate branch 3 times, most recently from d2ac192 to 7d183f9 Compare March 27, 2019 14:10
@Praveen2112 Praveen2112 force-pushed the distinct_in_predicate branch 3 times, most recently from 6a3a189 to 6045f96 Compare March 29, 2019 06:49
@Praveen2112
Copy link
Member Author

@martint , @kokosing I have updated it. Please take a look at them

kokosing
kokosing approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments.

...-main/src/main/java/io/prestosql/sql/planner/iterative/rule/RemoveAggregationInSemiJoin.java Outdated Show resolved Hide resolved
...-main/src/main/java/io/prestosql/sql/planner/iterative/rule/RemoveAggregationInSemiJoin.java Show resolved Hide resolved
...-main/src/main/java/io/prestosql/sql/planner/iterative/rule/RemoveAggregationInSemiJoin.java Outdated Show resolved Hide resolved
@kokosing kokosing merged commit 79083f7 into trinodb:master Apr 1, 2019
@kokosing
Copy link
Member

kokosing commented Apr 1, 2019

Merged, thanks!

@kokosing kokosing added this to the 307 milestone Apr 1, 2019
@kokosing kokosing mentioned this pull request Apr 1, 2019
Closed
6 tasks
@martint
Copy link
Member

martint commented Apr 3, 2019

Fixes #11

@kokosing kokosing mentioned this pull request Apr 3, 2019
Closed
@ankitdixit ankitdixit mentioned this pull request May 13, 2019
Closed
@Praveen2112 Praveen2112 deleted the distinct_in_predicate branch May 18, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint left review comments

@kokosing kokosing kokosing approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
307
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Praveen2112 @kokosing @martint