New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter sys schema on MySQL #6337
Conversation
@findepi Do you think we can just hide this schema? The |
I think it's not unreasonable to hide it. I don't have a strong opinion though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove 8
from commit title since it's not specific to the version.
presto-mysql/src/main/java/io/prestosql/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
f3cda55
to
b8d9476
Compare
Thanks @ebyhr, requested change made. |
presto-mysql/src/main/java/io/prestosql/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
presto-mysql/src/main/java/io/prestosql/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
@ebyhr Pushed changes now. Apologies for forgetting this |
Merged, thanks! |
On MySQL 8 has a new sys schema that's used in conjunction with the performance schema, we should hide this as well. See this for details https://dev.mysql.com/doc/refman/8.0/en/sys-schema.html