Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Joda Time and Jackson #6660

Merged
merged 2 commits into from Jan 25, 2021
Merged

Update Joda Time and Jackson #6660

merged 2 commits into from Jan 25, 2021

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 20, 2021

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 20, 2021
@wendigo wendigo requested a review from martint January 20, 2021 15:29
@findepi findepi changed the title Pick versions from airbase Update Joda Time and Jackson Jan 20, 2021
losipiuk
losipiuk reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sth red

@wendigo
Copy link
Contributor Author

wendigo commented Jan 20, 2021

@losipiuk I've fixed failing tests. Please review it now.

losipiuk
losipiuk reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would like someone else to look at timezone commit.

@wendigo wendigo requested a review from losipiuk January 20, 2021 18:50
findepi
findepi reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dain @martint wanna take a look into TZ change as well?
otherwise gonna merge this

core/trino-main/src/test/java/io/trino/util/TestTimeZoneUtils.java Show resolved Hide resolved
@wendigo
Pick Joda version 2.10.9 from airbase
6877652 
US/Pacific-New timezone was removed in zoneinfo 2020b.
According to https://www.oracle.com/java/technologies/tzdata-versions.html
JDK 11 has updated tzinfo data since version 11.0.10.
@wendigo
Pick Jackson version 2.11.4 from airbase
6d250da
@wendigo wendigo requested a review from findepi January 22, 2021 18:44
@wendigo
Copy link
Contributor Author

wendigo commented Jan 25, 2021

Failed due to #5758 in iceberg

@findepi findepi merged commit 090cc95 into trinodb:master Jan 25, 2021
@findepi findepi added this to the 352 milestone Jan 25, 2021
@findepi findepi mentioned this pull request Jan 25, 2021
Closed
10 tasks
@wendigo wendigo deleted the serafin/update-joda-version branch January 25, 2021 13:21
@electrum electrum mentioned this pull request Jan 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum Awaiting requested review from electrum

@martint martint Awaiting requested review from martint

@losipiuk losipiuk Awaiting requested review from losipiuk

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
352
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wendigo @findepi @losipiuk