Do not allow to INSERT into a table with row filter #7346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Mar 18, 2021
| @@ -405,4 +405,16 @@ public void testUpdate() | |||
| assertThatThrownBy(() -> assertions.query("UPDATE orders SET totalprice = totalprice * 2 WHERE orderkey IN (10, 20, 30)")) | |||
There was a problem hiding this comment.
Typo in commit message: filterring
findepi
reviewed
Mar 18, 2021
| @@ -415,7 +415,7 @@ protected Scope visitInsert(Insert insert, Optional<Scope> scope) | |||
|
|
|||
| for (ColumnMetadata column : columns) { | |||
| if (!accessControl.getColumnMasks(session.toSecurityContext(), targetTable, column.getName(), column.getType()).isEmpty()) { | |||
| throw semanticException(NOT_SUPPORTED, insert, "Insert into table with column masks"); | |||
| throw semanticException(NOT_SUPPORTED, insert, "Insert into table with column masks is not supported"); | |||
There was a problem hiding this comment.
This is at least consistent with the analogous message for UPDATE, see e.g. line 1866 and 1873
There was a problem hiding this comment.
kokosing@m16:~/presto$ grep -i 'not allowed' ./core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
throw semanticException(INVALID_COLUMN_REFERENCE, reference, "LATERAL reference not allowed in %s JOIN", node.getType().name());
throw semanticException(COLUMN_NOT_FOUND, allColumns, "SELECT * not allowed from relation that has no columns");
throw semanticException(COLUMN_NOT_FOUND, allColumns, "SELECT * not allowed in queries without FROM clause");
throw semanticException(COLUMN_NOT_FOUND, allColumns, "SELECT * not allowed from relation that has no columns");
// Since RECURSIVE is specified, any reference to WITH query name is considered a recursive reference and is not allowed.
throw semanticException(INVALID_RECURSIVE_REFERENCE, recursiveReferences.get(0), "recursive reference not allowed in this context");
kokosing@m16:~/presto$ grep -i 'not supported' ./core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
throw semanticException(NOT_SUPPORTED, node, "USE statement is not supported");
throw semanticException(NOT_SUPPORTED, insert, "Inserting into materialized views is not supported");
throw semanticException(NOT_SUPPORTED, insert, "Inserting into views is not supported");
throw semanticException(NOT_SUPPORTED, insert, "Insert into table with a row filter is not supported");
throw semanticException(NOT_SUPPORTED, insert, "Insert into table with column masks is not supported");
throw semanticException(NOT_SUPPORTED, node, "Deleting from views is not supported");
throw semanticException(NOT_SUPPORTED, node, "Analyzing views is not supported");
throw semanticException(NOT_SUPPORTED, node, "Natural join not supported");
throw semanticException(NOT_SUPPORTED, update, "Updating through views is not supported");
throw semanticException(NOT_SUPPORTED, update, "Updating a table with a row filter is not supported");
throw semanticException(NOT_SUPPORTED, update, "Updating a table with column masks is not supported");
// filter with window function is not supported yet
throw semanticException(NOT_SUPPORTED, windowFunction, "Window function with ORDER BY is not supported");
throw semanticException(NOT_SUPPORTED, allColumns, "Column aliases not supported");
throw semanticException(NOT_SUPPORTED, node.getSelect(), "SELECT * from outer scope table not supported with anonymous columns");
throw semanticException(EXPRESSION_NOT_IN_DISTINCT, expression, "Non deterministic ORDER BY expression is not supported with SELECT DISTINCT")
This is coherent with the current convention. I see your point so I created an issue for this, see: #7369
| USER, | ||
| new ViewExpression(USER, Optional.empty(), Optional.empty(), "nationkey < 10")); | ||
| assertThatThrownBy(() -> assertions.query("INSERT INTO nation VALUES (26, 'POLAND', 0, 'No comment')")) | ||
| .hasMessage("This connector does not support inserts"); |
There was a problem hiding this comment.
This looks wrong. We should be testing with a connector which does support inserts, or make a mock connector pretend it does that.
There was a problem hiding this comment.
Let me squash this commit then to avoid imperfect intermediate state.
| @@ -407,6 +407,10 @@ protected Scope visitInsert(Insert insert, Optional<Scope> scope) | |||
| } | |||
| accessControl.checkCanInsertIntoTable(session.toSecurityContext(), targetTable); | |||
|
|
|||
| if (!accessControl.getRowFilters(session.toSecurityContext(), targetTable).isEmpty()) { | |||
| throw semanticException(NOT_SUPPORTED, insert, "Insert into table with a row filter is not supported"); | |||
ksobolew
approved these changes
Mar 19, 2021
kokosing
force-pushed
the
origin/master/300_insert
branch
from
5b656d3
to
6395ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow to INSERT into a table with row filter