Remove redundant TypeProvider creation at PlanPrinter #8650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Jul 23, 2021
| @@ -386,6 +386,16 @@ private static String formatFragment( | |||
| return builder.toString(); | |||
| } | |||
|
|
|||
| private static TypeProvider getTypeProvider(List<PlanFragment> fragments) | |||
| { | |||
| // somewhat faster than java stream | |||
There was a problem hiding this comment.
This is true, but we optimize coordinator code for readability.
While we have a rule not to use Streams in performance sensitive code (like query execution), planner uses streams a lot.
Is this place any special?
There was a problem hiding this comment.
Ok, I see. I think we could use the streams here.
| // somewhat faster than java stream | ||
| Map<Symbol, Type> symbols = new HashMap<>(); | ||
| for (PlanFragment fragment : fragments) { | ||
| fragment.getSymbols().forEach(symbols::put); |
There was a problem hiding this comment.
previous code used distinct on entries, so any duplicates where "coherent"
Here, you overwrite entries in symbols without checking that symbol types do agree.
Please verify that.
Best way to do it is by using toImmutableMap collector or ImmutableMap.builder().
kokosing
approved these changes
Jul 26, 2021
This was referenced Jul 27, 2021
|
@kokosing looks good to merge? |
|
I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes hit high coordinator CPU usage at generating text query plan. We found that tens of threads were generating test query plan at query-completion event. More specifically, it was building the same TypeProvider from fragments per each stage. When there're huge fragments and symbols in a query, building TypeProvider from all symbols could be heavy task so it should be generated once and reused.