Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tinyint and smallint when reading Iceberg ORC files #8919

Closed
Tracked by #1324
electrum opened this issue Aug 19, 2021 · 1 comment · Fixed by #12089
Closed
Tracked by #1324

Support tinyint and smallint when reading Iceberg ORC files #8919

electrum opened this issue Aug 19, 2021 · 1 comment · Fixed by #12089
Assignees
@ebyhr

Comments

@electrum
Copy link
Member

electrum commented Aug 19, 2021 •
edited

The specification says that "ORC tinyint and smallint would also map to int" so we should support that on read. For write, we should continue to only write int. Note that these are called BYTE and SHORT in the ORC reader.
@findepi findepi mentioned this issue Nov 23, 2021
Closed
93 tasks
@ebyhr ebyhr self-assigned this Apr 19, 2022
@ebyhr
Copy link
Member

ebyhr commented Apr 21, 2022

As far as I confirmed, smallint works without issues, but reading tinyint ORC type would fail.

@ebyhr ebyhr mentioned this issue Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebyhr ebyhr

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support reading ORC tinyint type in Iceberg ebyhr/trino
2 participants
@electrum @ebyhr