Fix Hive target max file size for partitioned tables #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Oct 8, 2021
findepi
reviewed
Oct 8, 2021
| HiveWriter writer = writers.get(writerIndex); | ||
| if (writer != null) { | ||
| // if current file not too big continue with the current writer | ||
| if (bucketFunction != null || writer.getWrittenBytes() <= targetMaxFileSize.orElse(Long.MAX_VALUE)) { |
There was a problem hiding this comment.
Why bucketFunction != null condition? we support multiple files per bucket.
also are there any disdvantages to calling writer.getWrittenBytes() <= targetMaxFileSize.orElse(Long.MAX_VALUE) per page position?
findepi
reviewed
Oct 8, 2021
| @Test | ||
| public void testTargetMaxFileSizePartitioned() | ||
| { | ||
| @Language("SQL") String createTableSql = "" + |
There was a problem hiding this comment.
nit: if you have new enough Intellij, @Language("SQL") on variables is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9434