Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferring applicationId retrieval to when the publishApkTask runs #54

Closed
ZacSweers opened this issue Mar 23, 2015 · 2 comments · Fixed by #55
Closed

Deferring applicationId retrieval to when the publishApkTask runs #54

ZacSweers opened this issue Mar 23, 2015 · 2 comments · Fixed by #55

Comments

@ZacSweers
Copy link
Contributor

Right now, the applicationId is captured at configuration and persisted throughout the PlayPublishTask's lifetime, even though a build might dynamically change the applicationId after that. Retrieving the APK file would run into the same issue if the developer set custom APK names, but it doesn't run until the PlayPublishApkTask runs, and thus retrieves the correct final name after the app has been assembled. My proposal is to do the same with applicationId. I think it would be an easy change, since the variant instance is held in the PlayPublishApkTask.

In PlayPublishApkTask, instead of using the saved applicationId field, we can simply call variant.applicationId. I think this should work, though it might have to be variant.mergedFlavor.applicationId (I'm not entirely sure if they can ever be different).

If you're open to it, I'd be happy to send a pull request your way.

@bhurling
Copy link
Contributor

Sounds good.

@ZacSweers
Copy link
Contributor Author

Great, I'll get started on it tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants