TripleA 2.6.33.8af5587ac3 crashes some maps with centers.txt error

[TheDog-GH]

https://github.com/triplea-game/triplea/releases/tag/2.6.33.8af5587ac3

The above version causes this error before the 1st turn completes

On this map and crashes TripleA
https://triplea-game.org/map/ww2-oil-and-snow-2nd-edition/
It also causes the same error on this unpublishing map
The Shogun Advanced

All versions after the above version cause the same error
This version and before
https://github.com/triplea-game/triplea/releases/tag/2.6.13%4057528d46ee
do not have this error.

see TripleA forum for other posts
https://forums.triplea-game.org/topic/2998/2-6-testing-report-2-6-problems-here/48?page=3

[beelee1]

I cant test with pre release. Does it do it with other maps ? revised or global being two of the more popular ones

[TheDog-GH]

I dont play on many ww2 maps, I did test the Napoleonic map and it does not crash it.

The crash happens within seconds of launching an all AI game on
ww2-oil-and-snow-2nd-edition
The Shogun Advanced

Strangely the crash does not occur on the published The Shogun map, which shares lots of code/text with The Shogun Advanced map.

[beelee1]

Hmm ... seems as if it doesn't like something with the way the map is set up. With the centers that is. I think that means where stuff is located on the map ? Not real knowledgeable about the graphics part of triplea.

@WCSumpton you run into this before ?

[TheDog-GH]

To be clearer this crash error effects all versions after 2.6.33.8af5587ac3

The map Im currently working on/building also crashes with the same error, so I cannot test the latest version of TripleA.

[asvitkine]

I just tried ww2 oil and snow on current 2.6 HEAD and I'm not seeing a centers.txt error.

I do get a different error in an all-AI game (during British purchase phase):
java.lang.IllegalStateException: Round 10,000 reached in a battle. Something must be wrong. Please report this to TripleA. Attacking unit types: bomber,leadershipOffensive, Defending unit types: seamines

[TheDog-GH]

Im not sure which version 2.6 HEAD is, but downloaded 2.6.791 and still has the same error centers.txt error

Here is a link to Shogun Advanced, its not published or complete, it has the same error
https://drive.google.com/file/d/15c3lgecpoQrNztT_zvksFio5Fx8hPWo6/view?usp=sharing

Attached triplea.log deleted it, then running both ww2 oil and snow & Shogun Advanced to get the error.
triplea.log

This might be unrelated but in TripleA-2.5.22294 these game notes load correctly but in 2.6 they are;
ww2 oil and snow - missing icons

.
.
Shogun Advanced - missing the whole Game_notes.png

It does not use the conventional game notes method, it has;
<br><center><img src="Game_Notes.png"/></center>

In 2.5.22294 these games both display as intended.

[asvitkine]

I downloaded the Shogun map and it's working fine for me (on 2.6.791), not getting a centers.txt error.

If I open Game Notes, it looks like this:

Can you give more details about your set up for triplea? Do you have a custom maps folder configured or is it the default? Are you placing the zip file in the maps folder - or placing the unzipped folder directly? (I did the latter.)

On WW2 oil and snow, I also see the images fine in Game Notes.

[TheDog-GH]

Im on Windows 10 64bit, Java version
C:\Users\RYZEN>java -version
java version "1.8.0_331"
Java(TM) SE Runtime Environment (build 1.8.0_331-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.331-b09, mixed mode)

I have multiple versions of TripleA and put them in folders like TripleA-2.6.791
Change the TripleA.vmoptions file to;
-Xmx3072M
-Xms3072M
-Xss1536K

Use the downloadedMaps (its not customised)

Place the the unzipped map in the downloadedMaps folder (sometimes write a map.yml for old maps I have unzipped)

ww2_oil_and_snow_2nd_edition\map has a "map" folder like your imperialism_1974_board_game
the_shogun_advanced does not have a maps folder

Just downloaded 2.6.791 again and did a default install to TripleA folder and left the TripleA.vmoptions as intended.
Both maps still error with the centers.txt

Ebbe who wrote/designed Oil & Snow is also on Windows 10 64 , has exactly the same problem as I do.

the_shogun is the basic version of the_shogun_advanced
the_shogun does as intended and does not centers.txt error and shows the Game Notes as intended
Copying the
<br><center><img src="Game_Notes.png"/></center> and the Game_Notes.png from the_shogun to the_shogun_advanced errors in advanced and works in basic :-/

This is what the Game_Notes.png should look like

In your screen shot there should be a broken image but it is not displayed. (I get the same, no broken image icon)

.
I traced the start of this error back to this version
TripleA 2.6.33.8af5587ac3 crashes some maps with centers.txt error

So perhaps comparing the code with the prior version will aid you in tracking down the fault?

Thanks for taking the time to look at this.

[asvitkine]

I tried on Windows and am seeing the error, so I can debug. Interesting that it doesn't happen on Mac.

[asvitkine]

OK, I think the problem is that there is a polygons.txt file in the 'baseTiles' folder for the ww2 oil map. So the game decides that's the right place to look for all the other files. I think if that file is removed, it will work correctly.

I can see if I can change it to first consider files that are closer to the root dir, since there is a polygons.txt file in the root dir too.

[TheDog-GH]

As Winnie-the-Pooh would say " Oh Bother", I would say something stronger. :-P

I can confirm by removing the incorrect polygons.txt in both O&S and The Shogun Advanced, they both work as intended.

Please dont change anything on account of our school boy error, the polygons.txt is not supposed to be in baseTiles

Thanks for getting to the 'root' of the problem. :-)

I am going to close this thread.

[asvitkine]

I'm still going to improve things here because at the very least the inconsistent behavior between Mac and Windows can create confusion and waste people's time.

[TheDog-GH]

Fair enough. 👍