-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Google Location Data import experience #69
Comments
Another thought from Google Play store:
Let's consider adding instructions for those who are worried about this. They can do it independently -- although the fact that it is open source does allow them to see what is happening behind the scenes, too. |
I had several options from Google Takeout and I didn't know which to select. The instructions should likely give advice on these:
I think resolving this would likely also fix #114. |
I just tried PrivateKit version 0.5.11 on android 10, and can confirm the import functionality is confusing; I got it to download, but was confused about whether it succeeded. After ten minutes I did see my trace show imported data, so it does work, it's just hard for non-computer-types to use. |
Completely agree with this. Extract from my recent test report: https://docs.google.com/document/d/1Uh1A-h7Ddm6t-rAlHOM90xnsrkLEG9SGcTolf3uIbgQ/edit "[DHM-S1-9 - Existing 69] I see a lot of problems with the embedded Google panel. It creates a complex UI, that I think many users will not be able to successfully navigate. If possible, it would be much preferable to have this function available natively in the App, with a simplified UX. Unlike other users, I was not able to get the import to succeed, but I'll raise that as a separate issue. |
Further evidence that the UX is very problematic. I let my wife try to run through the proces without briefing on her phone. Several novel problems hit:
|
Please note ... #410 is is progress that will rework this experience. |
Is this a duplicate of #410? Shall we just close this, or does this add anything extra? |
#410 is the code change to improve the import flow: Lets try to get some of these UX issue fixed, but be aware that Google does not provide a nice progrmmable interface to getting this data because it is inside their account settings, so there will be some UX issues that we cannot solve. But we can hopefully imporove the text guides, or descriptions so that users can complete the journey effectively. |
This look very nice! But the mere potential, that the user has 1 GB to download, is quite a scary idea. What will happen to a lot of people is the following:
Worst case scenario:
That said, we should warn users to only download when on a reliable WiFi connection. |
Actual data usage if they just check location is much lower. (i.e. the Google Takeout The remaining wording is scary, but that's a minor problem. |
@dankegel What do you mean with |
well, I think we are trying to go too far in a single code change and maybe baby steps made iteratively would be a better option. let me explain current state of import feature in
PR #410 is bringing in:
Yes, there might be a concern with big files, somebody mentioned 7 years of locations is about 500mb. Unfortunately, Take out provides only one option to download either all or no locations, no option to select time range. Thanks for testing and the feedback, at the moment it's kind of hard to extract any actionable points other than updating the instructions, so further suggestions/guidance is still needed. Yeah, even improved version still requires more improvements 😄 but if user follows instructions and downloads either through link or google drive it should be no problem importing. If it was up to me, I'd suggest to wrap up and merge #410 as I believe something (what works) is better than nothing, keep the improvement conversation and open another PR when it makes sense. |
Yes I agree that we should get #410 merged soon, and we can improve the instructions/steps if they need more clarification |
The Import functionality is great, but still tricky to use. It might take a few iterations to get it to what we want, but here are some thoughts:
Break the Import into three stages, kinda like an old-school Wizard.
Explain what this does and give instructions to log in and start the process w/Google.
Q: Can we explore the DOM on the webview? It would be cool to watch for an indicator that the request for a takeout has happened, then move to the "Waiting" step described below.
If the user returns to Import page, show a message that we are still waiting on the takeout file.
Include a "Start over" button to go back to Step 1 in case something fails.
After an import completes, the results of the import should be remembered and displayed. E.g.
"28 day of data imported from Mar 1 - Mar 28".
Also have an "Import again" button that goes back to step 1.
During Step 2 the user should be be able to leave the app or go back to the main page. We should have a background task look for the takeout file when one is pending, so you don't have to go back to Import. The app should show a notification when the takeout file is found and process completes.
Discussion is welcome. I expect the implementer will find challenges and opportunities to improve this sequence. For instance, there might be a step 2.5 that helps with the download of the Takeout file.
The text was updated successfully, but these errors were encountered: