-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Import from webview to file picker #282
Conversation
…e-kit into import_picker
Once we have the dust fully settled from the rename to covid safe paths, we need to consider pulling this in, possibly for v1.0 |
@rparet, I started digging into issues #73 and #77 and I figured that the code from this PR would need to be merged first before addressing them. FYI, Import feature is currently not really working properly in develop branch (need to parse takeout data for last 2 months, exceptions are thrown if files do not exist, racing conditions as async code is written in a sync way). Also, I'd like to offer some help to make this PR merged faster as I sort of got your idea and have an understanding how to address mentioned import issues. |
@sergesemashko Can you branch off from the following one - |
@tremblerz , I've checked import_picker and I can see an exception on an attempt to open file for month that does not exist in takeout report. I can take a look into it and resolve conflicts from develop branch |
@sergesemashko that condition also exists on the current importer. It only looks for this month's date file, which is problematic in 2 ways: 1. at the start of the month (like now), a customer will only be able to import a short amount of date. 2. the import fails silently for people who don't have this month's data, which can be a lot of people if they turned location history off at any time in the last 12-24 months. |
@rparet, yeah, picker solution seems to be friendlier. I can take a look at ENOENT and parsing latest 2 months of data and will open a PR soon. |
closing in favor of rebased #410 |
Changes the Import screen and instructions from loading a web view to instructing the customer to get their takeout data from Google and then load it into PrivateKit using a file picker.
Tested on iOS and Android via Google Drive / iCloud Drive.