Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt photos as streams #29

Closed
vin047 opened this issue Oct 4, 2021 · 0 comments
Closed

Encrypt photos as streams #29

vin047 opened this issue Oct 4, 2021 · 0 comments
Labels
code architecture Architectural code changes
Projects
Product Roadmap
Milestone
2.1.8

Comments

@vin047
Copy link
Contributor

vin047 commented Oct 4, 2021

Photos are currently loaded into memory and encrypted in full, using a custom Protobuf format for storing the key and data packets.

Instead, photos should use the streaming API and be encrypted as standard PGPMessages, which is currently used for videos only.

  1. Encrypt new photos with streaming API and store as standard PGPMessages.
  2. Decrypt newer photos with streaming API.
  3. Provide fallback decryption for photos encrypted the old way (until migration upgrade is implemented).

Note: this should hopefully resolve #24 too.
@vin047 vin047 added the code architecture Architectural code changes label Oct 4, 2021
@vin047 vin047 added this to the 2.1.8 milestone Oct 4, 2021
@vin047 vin047 added this to Later in Product Roadmap via automation Oct 4, 2021
@vin047 vin047 moved this from Later to Now in Product Roadmap Oct 4, 2021
@vin047 vin047 closed this as completed in 6e27ebf Nov 6, 2021
Product Roadmap automation moved this from Now to Completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code architecture Architectural code changes
Projects
Product Roadmap
Completed
Milestone
2.1.8
Development

No branches or pull requests
1 participant
@vin047