Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No windows support #1

Open
voltflake opened this issue Dec 10, 2022 · 7 comments
Open

No windows support #1

voltflake opened this issue Dec 10, 2022 · 7 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@voltflake
Copy link

I tried out ZVM and noticed that help menu was broken. A quick look at source guided me here so posting an issue for it.
image
Looks like these color codes doesn't work for windows systems (

@tristanisham
Copy link
Owner

Hey @danyildiabin,

The color codes do work on Windows, just not in Command Prompt. If you use PowerShell >7 they should work perfectly.
image

Still, I can see how that is annoying. I'll see what I can do to make colors optional so you don't have to see that 😊.

@tristanisham tristanisham self-assigned this Dec 12, 2022
@tristanisham tristanisham added bug Something isn't working enhancement New feature or request labels Dec 12, 2022
@tristanisham
Copy link
Owner

Oh my god. Oops! I thought this was the ZVM repo! My bad! Still, for ZVM there's a new update where you can turn colors off. I'll work on making a global fix through color though in the meantime! Thanks for raising this issue! @danyildiabin

@tristanisham
Copy link
Owner

@danyildiabin While I work on this, here's a ZVM update to fix your problem! https://github.com/tristanisham/zvm/releases/tag/v0.1.2

@voltflake
Copy link
Author

The color codes do work on Windows, just not in Command Prompt. If you use PowerShell >7 they should work perfectly.

I used default version installed on my windows 10 machine (ps 5.1), my bad. Glad it works on newer versions.

@tristanisham
Copy link
Owner

@danyildiabin Unfortunately, I don't think it's possible to wrap specific words or strings in color codes with command prompt. You can only set global shell colors like text, background, and borders. I'll keep looking though.

Did the fix I added to ZVM help at all?

@voltflake
Copy link
Author

I did some research and figured that all recent windows versions come with ps5.1 installed and are hard to replace properly with newer one.
Found this info about coloring in powershell and probably old cmd.exe. Hope it helps.

@voltflake
Copy link
Author

voltflake commented Dec 13, 2022

Did the fix I added to ZVM help at all?

Yes, colors can now be switched on/off. Works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants