-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Cannot move zls #85
Comments
This is also an issue on arch linux, but the pull request should fix it on all distros and os' |
Hey @KeithBrown39423 I wrote two small proposals that need to be addressed before a merge, but I'll just do them tonight off of your PR if you can't get to it by then. |
Referencing #83, which was about this identical issue and has been closed even though it was the first. More progress has been made on this issue. |
It appears that in 0.11.0 ZLS is stored in a bin directory which makes this more complicated |
We can have a check. If the file existed we can move it from bin. If the files are in the root like the new version then we can unbundle using the modern feature. |
We could even just have a recursive crawl since I'm pretty sure ZLS is compiled statically, no? |
It seems that the layout of the release archive has changed since 0.12.0. Before merging the PR, I think it's important to consider support for older versions. ZLS looks like is a static executable so it's safe to just copy it into
Second option is to determine and choose the layout based on downloaded ZLS version. More future-proof, in case ZLS changes the layout again... |
Okay, I merged the pull request, but let's continue the work here: zls-hotix |
I've implemented recursive search of ZLS in #88. It works but has some flaws right now. It doesn't check whenever a candidate is actually an executable and uses |
@glyh does this match your issue? I'd like to consolidate all current ZLS errors into this issue if possible. |
Recursive search seems to have worked perfectly. Adding it to new release. If this doesn't solve the issue, we can reopen this issue. |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
zvm install --zls 0.12.0
Expected behavior
Install zig 0.12.0 along with zls
Error report
Desktop (please complete the following information):
Configuration:
The text was updated successfully, but these errors were encountered: