Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EventEmitter inheritance #17

Closed
fanatid opened this issue May 4, 2016 · 5 comments
Closed

Remove EventEmitter inheritance #17

fanatid opened this issue May 4, 2016 · 5 comments

Comments

@fanatid
Copy link
Contributor

fanatid commented May 4, 2016 •
edited

You can remove EventEmitter inheritance if allow pass ping function through options to constructor.

edit: with ping callback you can remove root argument
@feross
Copy link

feross commented May 4, 2016

I don't think it matters that much, but I'm okay with this.

@tristanls
Copy link
Owner

Implemented as of https://github.com/tristanls/k-bucket/releases/tag/v2.0.0

@fanatid
Copy link
Contributor Author

fanatid commented May 5, 2016

@tristanls Thank you!

@fanatid
Copy link
Contributor Author

fanatid commented May 5, 2016

Don't we harry with this? I found that events add and remove would be helpful..

@tristanls
Copy link
Owner

¯_(ツ)_/¯

@fanatid fanatid mentioned this issue May 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@feross @tristanls @fanatid