Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for format #98

Closed
zhulik opened this issue Sep 27, 2020 · 3 comments
Closed

Support for format #98

zhulik opened this issue Sep 27, 2020 · 3 comments

Comments

@zhulik
Copy link

zhulik commented Sep 27, 2020

Hello, thanks for this awesome project!

Are there any plans to add support for format?

I'd like to build a ruby gem on top of your library and missing support for format is a real blocker for my use cases

Thank you!

@tristanpenman
Copy link
Owner

As far as I remember, the reason for lacking format support is that when I first started writing this library, it wasn't very well defined. And I had completely forgotten about it since then. I'll take a look at what will be involved in supporting it, and post any progress on this issue.

@zhulik
Copy link
Author

zhulik commented Oct 2, 2020

@tristanpenman awesome, thank you! Here you can find a pure ruby imlementation that may be used as an example https://github.com/davishmcclurg/json_schemer/blob/master/lib/json_schemer/format.rb

@tristanpenman tristanpenman added this to the 0.4 milestone Nov 7, 2020
@tristanpenman tristanpenman removed this from the 0.4 milestone Aug 30, 2022
@tristanpenman
Copy link
Owner

After reviewing this issue, I think the addition of date/time format support is probably going to cover the most important use-cases for the format constraint. I'm going to close this issue, but feel free to re-open it if you find that other formats would be valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants