Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tritonhttpclient should support https #1624

Closed
24hours opened this issue Jun 5, 2020 · 0 comments · Fixed by #1684
Closed

Tritonhttpclient should support https #1624

24hours opened this issue Jun 5, 2020 · 0 comments · Fixed by #1684
Labels
enhancement New feature or request

Comments

@24hours
Copy link

24hours commented Jun 5, 2020

Is your feature request related to a problem? Please describe.
sometimes tritonserver is hosted behind some proxy with https termination. Currently tritonclient will error out when running infer function.

Describe the solution you'd like
tritonhttpclient should support https.
https://github.com/NVIDIA/triton-inference-server/blob/master/src/clients/python/library/httpclient.py#L161
this line assume all url is http:// only.
perhaps additional flag secure=True can be included.

Additional context
I'm currently running master branch to test cloud deployment.
@deadeyegoodwin deadeyegoodwin added the enhancement New feature or request label Jun 9, 2020
@tanmayv25 tanmayv25 linked a pull request Jun 18, 2020 that will close this issue
Enabling HTTPS in python HTTP client library #1684
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling HTTPS in python HTTP client library triton-inference-server/server
2 participants
@24hours @deadeyegoodwin