-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buddy does not deregister service from consul. #17
Comments
It's a known limitation. It was in the README at one point (ref cadb5e6) but it looks like I missed it when I moved the Roadmap items into Github issues. Let's mark this issue as an enhancement. |
This is an interesting question in the context of marking nodes for maintenance. Should that process accept two signals: one will suspend health checks and mark the service as down, or another (new) signal can fully remove it from Consul. Alternatively, marking nodes for maintenance could simply remove the service entirely on the current signal. I have mixed feelings about what's "correct" here. |
Something to think about here is that we have a limited number of signals at our disposal before we start possibly interfering with normal operations. If we use a signal for this:
And that's about it. The remaining signals are going to be used by the OS to manage the container or are just not right semantically. Another thing to note here is that if the container halts on its own (i.e. it crashes), we still end up with nodes left behind in Consul. But I don't know... maybe that's ok because it differentiates between nodes intentionally removed and nodes involuntarily removed? |
I almost hate to suggest this, but one way out of the signal namespace problem is to have a sock in the container (a la |
@misterbisson and I had a phone call about this and we've realized that the method we're using in #15 is limiting us here. If we reap the service from the discovery service instead of simply sending a I'm going to update #15 in lieu of that. |
Included in release: https://github.com/joyent/containerbuddy/releases/tag/0.0.2-alpha |
I realized that if I stop and start the container containerbuddy does_not refresh the service ip address on consul. I would have to deregister the service manually. Is this a bug?
The text was updated successfully, but these errors were encountered: