Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-version flag is broken #85

Closed
tgross opened this issue Feb 24, 2016 · 4 comments
Closed

-version flag is broken #85

tgross opened this issue Feb 24, 2016 · 4 comments
Assignees

Comments

@tgross
Copy link
Contributor

tgross commented Feb 24, 2016

Running ./containerbuddy -version fails to bring up the Githash and Version identifiers:

docker run --rm -it -v build/containerbuddy:/containerbuddy debian:jessie /bin/bash
root@5823395a7845:/# ./containerbuddy -version
Version:
GitHash:

I've been able to verify that it works with the 0.1.2-RC build so presumably this got introduced when we moved the directories around in 0.1.3.

@tgross tgross added the bug label Feb 24, 2016
@tgross
Copy link
Contributor Author

tgross commented Feb 24, 2016

I can confirm we're passing the LDFLAGS we expect into the build container and that the build container is using them during go build:

cd /go/src/github.com/joyent/containerbuddy && go build -a -o /build/containerbuddy -ldflags "-X containerbuddy.GitHash=afd088a -X containerbuddy.Version=dev-build-not-for-release" ./

So I suspect we're just passing in the wrong values.

@tgross
Copy link
Contributor Author

tgross commented Feb 24, 2016

Should be fixed in #86

@tgross
Copy link
Contributor Author

tgross commented Feb 26, 2016

Per discussion in #86 I'm going to make a test for this too.

@tgross tgross self-assigned this Feb 26, 2016
@tgross tgross added open PR and removed open PR labels Feb 29, 2016
@tgross
Copy link
Contributor Author

tgross commented Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant