Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo - MUSKIE_MULTI_DC #17

Closed
neuroserve opened this issue Jan 9, 2018 · 2 comments
Closed

Typo - MUSKIE_MULTI_DC #17

neuroserve opened this issue Jan 9, 2018 · 2 comments

Comments

@neuroserve
Copy link

app_uuid="$(sdc-sapi /applications?name=manta | json -H uuid)" vs.
app_uuid="$(sdc-sapi /applications?name=manta | json -Ha uuid)"
@davepacheco
Copy link
Contributor

Code review: https://cr.joyent.us/3191

Testing notes: I ran the updated "app_uuid" by hand on my test machine and it works correctly where the previous one didn't:

[root@headnode (emy-10) ~]# app_uuid="$(sdc-sapi /applications?name=manta | json -H uuid)"
[root@headnode (emy-10) ~]# echo $app_uuid

[root@headnode (emy-10) ~]# app_uuid="$(sdc-sapi /applications?name=manta | json -Ha uuid)"
[root@headnode (emy-10) ~]# echo $app_uuid
e0af2010-b85d-434c-91be-01ae2a387dc9
[root@headnode (emy-10) ~]#

The change is make prepush-clean. I verified that the rendered change looks as I'd expect.

joyent-automation pushed a commit that referenced this issue Jan 10, 2018
#17 Typo - MUSKIE_MULTI_DC
7b09d79 
Reviewed by: Brian Bennett <brian.bennett@joyent.com>
Reviewed by: Tim Kordas <tim.kordas@joyent.com>
Approved by: Brian Bennett <brian.bennett@joyent.com>
davepacheco pushed a commit that referenced this issue Jan 10, 2018
#17 Typo - MUSKIE_MULTI_DC
c9417d1
@davepacheco
Copy link
Contributor

The change is integrated and published. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davepacheco @neuroserve